Daniel Erez has posted comments on this change. Change subject: webadmin: Add a warning when importing a Storage Domain ......................................................................
Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/35226/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java: Line 187: force_storage_domain_creation("force_storage_domain_creation", HelpTagType.WEBADMIN, "Storage Tab > New Domain > Confirm LUNs in Use"), //$NON-NLS-1$ //$NON-NLS-2$ Line 188: Line 189: import_storage_domain_confirmation("import_storage_domain_confirmation", HelpTagType.WEBADMIN, "Storage Tab > Import Domain > Confirm import storage domain"), //$NON-NLS-1$ //$NON-NLS-2$ Line 190: Line 191: attach_storage_domain_confirmation("attach_storage_domain_confirmation", HelpTagType.WEBADMIN, "Storage main-tab > Data Center sub-tab > Attach > Confirm attach storage domain"), //$NON-NLS-1$ //$NON-NLS-2$ * should be moved to http://gerrit.ovirt.org/#/c/34491/ * maybe add another one for: ''Data Center main-tab > Storage sub-tab >..." Line 192: Line 193: general("general", HelpTagType.UNKNOWN), //$NON-NLS-1$ Line 194: Line 195: gluster_bricks("gluster_bricks", HelpTagType.UNKNOWN), //$NON-NLS-1$ http://gerrit.ovirt.org/#/c/35226/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java: Line 500: model.setMessage(ConstantsManager.getInstance() Line 501: .getConstants() Line 502: .storageDomainsAttachedToDataCenterWarningMessage()); Line 503: Line 504: model.setHelpTag(HelpTag.attach_storage_domain_confirmation); all changes in file should be moved to http://gerrit.ovirt.org/#/c/34491/ Line 505: model.setHashName("attach_storage_domain_confirmation"); //$NON-NLS-1$ Line 506: Line 507: model.getLatch().setIsAvailable(true); Line 508: model.getLatch().setIsChangable(true); http://gerrit.ovirt.org/#/c/35226/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java: Line 429: model.setItems(stoageDomainNames); Line 430: Line 431: model.setTitle(ConstantsManager.getInstance().getConstants().storageDomainsAttachedToDataCenterWarningTitle()); Line 432: model.setMessage(ConstantsManager.getInstance().getConstants().storageDomainsAttachedToDataCenterWarningMessage()); Line 433: model.setHelpTag(HelpTag.attach_storage_domain_confirmation); all changes in file should be moved to http://gerrit.ovirt.org/#/c/34733/ Line 434: model.setHashName("attach_storage_domain_confirmation"); //$NON-NLS-1$ Line 435: model.getLatch().setIsAvailable(true); Line 436: model.getLatch().setIsChangable(true); Line 437: http://gerrit.ovirt.org/#/c/35226/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 267: public StorageType storageType; Line 268: public boolean removeConnection; Line 269: public List<StorageDomain> storageDomainsToAdd; Line 270: Line 271: @Override format Line 272: public boolean isSearchStringMatch(String searchString) Line 273: { Line 274: return searchString.trim().toLowerCase().startsWith("storage"); //$NON-NLS-1$ Line 275: } -- To view, visit http://gerrit.ovirt.org/35226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73b42baadc1c9f01d471dbac1e94d7793d30ab5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
