Daniel Erez has posted comments on this change. Change subject: core: Enable Live Merge in Snapshots Overview ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/32338/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java: Line 206: List<SPMAsyncTaskHandler> taskHandlers = new ArrayList<>(); Line 207: Line 208: // Sort images from parent to leaf (active) - needed only if empty Line 209: // as the sorted list is being saved in the parameters. Line 210: if (getParameters().getImageIds() == null) { Have you verified it from the UI? It should send the 'imageIds' array in RemoveDiskSnapshotsParameters's ctr. So this block would never be executed.. Line 211: // Retrieve and sort the entire chain of images Line 212: List<DiskImage> images = getAllImagesForDisk(); Line 213: ImagesHandler.sortImageList(images); Line 214: -- To view, visit http://gerrit.ovirt.org/32338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
