Alon Bar-Lev has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35361/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 25: Line 26: } Line 27: Line 28: private ConcurrentMap<String, SessionInfo> sessionInfoMap = new ConcurrentHashMap<>(); Line 29: private ConcurrentMap<String, Long> sessionToIdMap = new ConcurrentHashMap<>(); why can't the Long be in SessionInfo? Line 30: Line 31: private static final String USER_PARAMETER_NAME = "user"; Line 32: private static final String PASSWORD_PARAMETER_NAME = "password"; Line 33: private static final String AUTHN_PARAMETER_NAME = "authn"; Line 98: engineSession.setEngineSessionId(sessionId); Line 99: DbUser user = getUser(sessionId, false); Line 100: engineSession.setUserId(user.getId()); Line 101: engineSession.setUserName(user.getLoginName()); Line 102: engineSession.setGroupIds(user.getGroupIds()); I do not know the conventions of dao, but why can't we have a method that accept DbUser? Line 103: sessionToIdMap.put(sessionId, getDbFacade().getEngineSessionDao().save(engineSession)); Line 104: } Line 105: } Line 106: -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
