[Engine-patches] Change in ovirt-engine[master]: core: Removing transaction suspension from command saving/up...

[yzaslavs]

Yair Zaslavsky has uploaded a new change for review.

Change subject: core: Removing transaction suspension from command saving/update
......................................................................

core: Removing transaction suspension from command saving/update

Change-Id: I885b1d08e6dc1ac00f6ca11bc6fca1df8f044d5f
Signed-off-by: Yair Zaslavsky  <yzasl...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
1 file changed, 4 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/35400/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
index 1ea5ac3..a915575 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
@@ -8,9 +8,6 @@
 import org.ovirt.engine.core.compat.DateTime;
 import org.ovirt.engine.core.compat.Guid;
 import org.ovirt.engine.core.dal.dbbroker.DbFacade;
-import org.ovirt.engine.core.utils.transaction.TransactionSupport;
-
-import javax.transaction.Transaction;
 
 public class CommandsCacheImpl implements CommandsCache {
 
@@ -57,7 +54,7 @@
     @Override
     public void put(final CommandEntity cmdEntity) {
         commandMap.put(cmdEntity.getId(), cmdEntity);
-        saveOrUpdateWithoutTransaction(cmdEntity);
+        saveOrUpdate(cmdEntity);
     }
 
     public void removeAllCommandsBeforeDate(DateTime cutoff) {
@@ -70,7 +67,7 @@
         final CommandEntity cmdEntity = get(commandId);
         if (cmdEntity != null) {
             cmdEntity.setCommandStatus(status);
-            saveOrUpdateWithoutTransaction(cmdEntity);
+            saveOrUpdate(cmdEntity);
         }
     }
 
@@ -82,15 +79,8 @@
         }
     }
 
-    public void saveOrUpdateWithoutTransaction(CommandEntity cmdEntity) {
-        Transaction transaction = TransactionSupport.suspend();
-        try {
-            
DbFacade.getInstance().getCommandEntityDao().saveOrUpdate(cmdEntity);
-        } finally {
-            if (transaction != null) {
-                TransactionSupport.resume(transaction);
-            }
-        }
+    public void saveOrUpdate(CommandEntity cmdEntity) {
+        DbFacade.getInstance().getCommandEntityDao().saveOrUpdate(cmdEntity);
     }
 
     public void updateCallBackNotified(final Guid commandId) {


-- 
To view, visit http://gerrit.ovirt.org/35400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I885b1d08e6dc1ac00f6ca11bc6fca1df8f044d5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches