Roy Golan has posted comments on this change. Change subject: webadmin: make it more obvious that thread as cores is enabled ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33485/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java: Line 256: Line 257: Line 258: String fieldValue = String.valueOf(coresPerSocket); Line 259: if (vds.getCountThreadsAsCores()) { Line 260: fieldValue = ConstantsManager.getInstance().getMessages() same question about NPE like in ovirt-engine-3.5. patch Line 261: .threadsAsCoresPerSocket(coresPerSocket, vds.getCpuThreads()); Line 262: } Line 263: Line 264: setCoresPerSocket(fieldValue); -- To view, visit http://gerrit.ovirt.org/33485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fb9d28f3b125a9104fec5f3a887efdbf711b037 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
