Liron Aravot has posted comments on this change. Change subject: core: Push ioTune QoS info when hotplugging disk ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/33907/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 353: ArchStrategyFactory.getStrategy(vm.getClusterArch()).run(new CreateAdditionalControllers(devices)); Line 354: } Line 355: Line 356: static void addIoTuneParams(VM vm, VmDevice vmDevice, Map<String, Long> ioTune) { Line 357: if (FeatureSupported.storageQoS(vm.getVdsGroupCompatibilityVersion())) { any reason that we won't use this if clause as it was used before? there's no need to perform the queries if it's not even supported (as was done before this patch)..not that it's the end of the world, but there's no obvious reason to change it. Line 358: if (ioTune != null) { Line 359: if (vmDevice.getSpecParams() == null) { Line 360: vmDevice.setSpecParams(new HashMap<String, Object>()); Line 361: } Line 354: } Line 355: Line 356: static void addIoTuneParams(VM vm, VmDevice vmDevice, Map<String, Long> ioTune) { Line 357: if (FeatureSupported.storageQoS(vm.getVdsGroupCompatibilityVersion())) { Line 358: if (ioTune != null) { you can merge the two if's in this line and the line above.. Line 359: if (vmDevice.getSpecParams() == null) { Line 360: vmDevice.setSpecParams(new HashMap<String, Object>()); Line 361: } Line 362: vmDevice.getSpecParams().put(VdsProperties.Iotune, ioTune); -- To view, visit http://gerrit.ovirt.org/33907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
