Piotr Kliczewski has posted comments on this change. Change subject: engine: Enhance the xml-rpc Long support to deal with Maps and Lists ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35355/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 320: map.put(entry.getKey(), longToString(entry.getValue())); Line 321: } Line 322: return map; Line 323: } else if (Collection.class.isInstance(object)) { Line 324: List<Object> list = new ArrayList<>(); Collection is a List or Set and here we always set a List. Is that intended? Line 325: for (Object entry: (Collection<Object>)object) { Line 326: list.add(longToString(entry)); Line 327: } Line 328: return list; -- To view, visit http://gerrit.ovirt.org/35355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
