Alon Bar-Lev has posted comments on this change. Change subject: core : Modify MLA to use engine session info ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35362/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 841 Line 842 Line 843 Line 844 Line 845 can't we have the dao contain the session id here, then avoid specifying it over and over? http://gerrit.ovirt.org/#/c/35362/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2313: String sessionId = null; Line 2314: if (getContext() != null && getContext().getEngineContext() != null) { Line 2315: sessionId = getContext().getEngineContext().getSessionId(); Line 2316: } Line 2317: return sessionId; can it be null? when? I think we should hold the id within database (primary key) in addition of session id and use this for the mla interaction to reduce performance issues. Line 2318: } -- To view, visit http://gerrit.ovirt.org/35362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
