Doron Fediuck has submitted this change and it was merged. Change subject: engine: handle memory allignment when checking the balloon health ......................................................................
engine: handle memory allignment when checking the balloon health Engine used to check if the ballooning works properly by comparing the target memory with the actual available memory and throws a warning if it doesn't match, the problem is when the requsted target memory value is not alligned. The system then returns the alligned memory and the engine thinks the balloon is not working, becuase the requested value != curent value. This patch changes the behaviour so it only checks if the current value is closer to the requested value than the previous value (in other words: if the current memory moves towards the requested target) Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9 Bug-Url: https://bugzilla.redhat.com/1120197 Signed-off-by: Jiri Moskovcak <jmosk...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBalloonInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
