Shubhendu Tripathi has posted comments on this change. Change subject: gluster: DAO for volume snapshot config maintenance ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/35303/2/packaging/dbscripts/upgrade/03_06_0520_add_gluster_volume_snapshot_tables.sql File packaging/dbscripts/upgrade/03_06_0520_add_gluster_volume_snapshot_tables.sql: Line 33: gluster_volumes(id) ON DELETE CASCADE; Line 34: Line 35: ALTER TABLE ONLY gluster_volume_snapshot_config Line 36: ADD CONSTRAINT fk_gluster_volume_snapshot_config_cluster_id FOREIGN KEY (cluster_id) REFERENCES Line 37: vds_groups(vds_group_id) ON DELETE CASCADE; > please use fn_db_create_constraint sure. will do that Line 38: Line 39: ALTER TABLE ONLY gluster_volume_snapshot_config Line 40: ADD CONSTRAINT fk_gluster_volume_snapshot_config_volume_id FOREIGN KEY (volume_id) REFERENCES Line 37: vds_groups(vds_group_id) ON DELETE CASCADE; Line 38: Line 39: ALTER TABLE ONLY gluster_volume_snapshot_config Line 40: ADD CONSTRAINT fk_gluster_volume_snapshot_config_volume_id FOREIGN KEY (volume_id) REFERENCES Line 41: gluster_volumes(id) ON DELETE CASCADE; > please use fn_db_create_constraint sure. will do that -- To view, visit http://gerrit.ovirt.org/35303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0854984eed0f72226aa732a651be50bf8dda9fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches