Alona Kaplan has posted comments on this change. Change subject: engine: Move getDefaultManagementNetworkName to ManagementNetworkUtils ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/34613/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImpl.java: Line 63: } Line 64: Line 65: /** Line 66: * Retrieves the default management network name from the {@link Config}. Line 67: * Should be used in very rare cases. <code>ManagementNetworkUtil</code> provides more appropriate solution for vast Now this method is in ManagementNetworkUtil the comment should be slightly updated. You can remove this comment, you have a correct comment on the interface. Line 68: * majority of the cases. Line 69: * Line 70: * @return the default management network name. Line 71: */ -- To view, visit http://gerrit.ovirt.org/34613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I659c5e929974911826c354d021ed6bf94516d22c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
