Liron Aravot has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) ......................................................................
Patch Set 7: answeres to mkublin comments: in case that you have only one active host in the pool, why wouldn't you try to reconstruct in order to make it useable? that's the scenario that this solution is meant to solve. if you don't reconstruct, the pool won't be connected to the host and it won't be spm. regarding the deadlock issue - i haven't added any lock, that two locks that are performed are unchanged and are present from before this patch - so I don't see how this may cause to a deadlock if the two locks are already present. regarding performance - if we don't reconstruct the host will be useless as it cannot connect to the pool and will fail spm selection, so i think that it better to wait another 3 minutes other than lose to option to use the pool. -- To view, visit http://gerrit.ovirt.org/7061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec43f368370da88f81dbe211331649a16c53f053 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
