Alona Kaplan has posted comments on this change. Change subject: engine: replace NetworkUtils.getDefaultManagementNetwork calls ......................................................................
Patch Set 28: (2 comments) http://gerrit.ovirt.org/#/c/34243/28/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java: Line 300: Line 301: return ValidationResult.VALID; Line 302: } Line 303: Line 304: public ValidationResult notRenamingManagementNetwork(Network newNetwork) { As I wrote on patchset 15, i"m not sure this validation is needed any more. Is there any special reason a management network name cannot be updated but a regular network can? Line 305: return managementNetworkUtil.isManagementNetwork(network.getId()) Line 306: && !network.getName().equals(newNetwork.getName()) Line 307: ? new ValidationResult(VdcBllMessages.NETWORK_CAN_NOT_REMOVE_DEFAULT_NETWORK) Line 308: : ValidationResult.VALID; Line 302: } Line 303: Line 304: public ValidationResult notRenamingManagementNetwork(Network newNetwork) { Line 305: return managementNetworkUtil.isManagementNetwork(network.getId()) Line 306: && !network.getName().equals(newNetwork.getName()) If you will explain me why this validation is needed, please use- !StringUtils.equals(network.getName(), newNetwork.getName())) Line 307: ? new ValidationResult(VdcBllMessages.NETWORK_CAN_NOT_REMOVE_DEFAULT_NETWORK) Line 308: : ValidationResult.VALID; Line 309: } Line 310: -- To view, visit http://gerrit.ovirt.org/34243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0bd50e16b577b3f31765011d9b16501149c2479 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
