Alona Kaplan has posted comments on this change. Change subject: engine: Update UpdateStoragePoolCommand logic ......................................................................
Patch Set 26: (3 comments) http://gerrit.ovirt.org/#/c/33822/26/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java: Line 154: canDoActionFailed(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 155: } Line 156: Line 157: @Test Line 158: public void lowerVersionHostsAndNetwork() { Please add test for lowerVersionMgmtNetworkAndRegularNetworks Line 159: storagePoolWithLowerVersion(); Line 160: addNonDefaultClusterToPool(); Line 161: addHostsToCluster(); Line 162: addNetworkToPool(); Line 163: canDoActionFailed(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 164: } Line 165: Line 166: @Test Line 167: public void lowerVersionMgmtNetworkSupportedFeatures() { Please add the same test for two management networks Line 168: storagePoolWithLowerVersion(); Line 169: addNonDefaultClusterToPool(); Line 170: addManagementNetworksToPool(TEST_MANAGEMENT_NETWORK_ID); Line 171: setupNetworkValidator(true); Line 342: } Line 343: when(networkDao.getAllForDataCenter(any(Guid.class))).thenReturn(managementNetworks); Line 344: } Line 345: Line 346: private Network createNetwork(Guid managementNetworkId) { the parameter can be just networkId, the method not related to management network. Line 347: Network network = new Network(); Line 348: network.setId(managementNetworkId); Line 349: return network; Line 350: } -- To view, visit http://gerrit.ovirt.org/33822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf3a156bd711f0f044d256bab8c514c33ca66aa2 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
