Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: Multi view table columns inconsitent ......................................................................
Patch Set 1: (2 comments) Order seems to behave correctly now, but the columns width aren't being saved after resize when moving between views.. http://gerrit.ovirt.org/#/c/35146/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java: Line 253 Line 254 Line 255 Line 256 Line 257 Are you sure it's redundant, maybe added for old browsers? Line 45: Line 46: // Prefix for keys used to store widths of individual columns Line 47: private static final String GRID_COLUMN_WIDTH_PREFIX = "GridColumnWidth"; //$NON-NLS-1$ Line 48: Line 49: //This is 1px instead of 0px as 0 size columns seem to confuse the cell table. Only in Chrome I guess...? A bit weird, but good enough :) Line 50: private static final String HIDDEN_WIDTH = "1px"; //$NON-NLS-1$ Line 51: Line 52: // Empty, no-width column used with resizable columns feature Line 53: // that occupies remaining horizontal space within the table -- To view, visit http://gerrit.ovirt.org/35146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I143894af611f8364da943433e81378690adcb0e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
