Alon Bar-Lev has posted comments on this change. Change subject: core: configurable ssl protocol ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34917/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java: Line 52: .<String> getValue(ConfigValues.AttestationServer); Line 53: // registering the https protocol with a socket factory that Line 54: // provides client authentication. Line 55: ProtocolSocketFactory factory = new AuthSSLProtocolSocketFactory(getTrustStore(trustStoreUrl.getPath(), Line 56: truststorePassword), "SSLv3"); sorry for late comment, but this shouldn't be based on vdsm protocol configuration as well? Line 57: Protocol clientAuthHTTPS = new Protocol("https", factory, port); Line 58: httpClient.getHostConfiguration().setHost(attestationServer, Line 59: port, clientAuthHTTPS); Line 60: } catch (Exception e) { -- To view, visit http://gerrit.ovirt.org/34917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
