Piotr Kliczewski has uploaded a new change for review. Change subject: ui: make protocol visible during host edit ......................................................................
ui: make protocol visible during host edit We would like to see protocol set for a host in edit mode. The protocol is modifable only when a host is moved to maintanance mode. Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Signed-off-by: pkliczewski <piotr.kliczew...@gmail.com> Bug-Url: https://bugzilla.redhat.com/1162229 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/35264/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java index 511cd41..b19d65a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java @@ -82,7 +82,7 @@ } @Override - protected boolean showTransportProperties(VDS vds) { + protected boolean editTransportProperties(VDS vds) { if (VDSStatus.Maintenance.equals(vds.getStatus())) { return true; } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java index 6bb538d..5121163 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java @@ -1773,7 +1773,7 @@ setHostId(vds.getId()); getOverrideIpTables().setIsAvailable(showInstallationProperties()); getProtocol().setEntity(VdsProtocol.STOMP == vds.getProtocol()); - getProtocol().setIsAvailable(showTransportProperties(vds)); + getProtocol().setIsChangable(editTransportProperties(vds)); setSpmPriorityValue(vds.getVdsSpmPriority()); setOriginalName(vds.getName()); getName().setEntity(vds.getName()); @@ -1899,7 +1899,7 @@ protected abstract boolean showInstallationProperties(); - protected abstract boolean showTransportProperties(VDS vds); + protected abstract boolean editTransportProperties(VDS vds); public abstract boolean showExternalProviderPanel(); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java index a88ce33..76557a1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java @@ -224,7 +224,7 @@ } @Override - protected boolean showTransportProperties(VDS vds) { + protected boolean editTransportProperties(VDS vds) { return true; } } -- To view, visit http://gerrit.ovirt.org/35264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
