Alona Kaplan has posted comments on this change. Change subject: engine: Add isManagementNetwork(String, Guid) to ManagementNetworkUtil ......................................................................
Patch Set 26: (1 comment) http://gerrit.ovirt.org/#/c/33816/26/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java: Line 145: public void testIsManagementNetworkNameNullInGivenCluster() throws Exception { Line 146: testIsManagementNetworkNameInGivenClusterCommon(null, TEST_CLUSTER_ID, false); Line 147: } Line 148: Line 149: private void testIsManagementNetworkNameInGivenClusterCommon(String managementNetworkName, Should be networkName (the management network is TEST_NETWORK_NAME) Line 150: Guid clusterId, Line 151: boolean expected) { Line 152: when(mockNetworkDao.getManagementNetwork(TEST_CLUSTER_ID)).thenReturn(mockNetwork); Line 153: when(mockNetwork.getName()).thenReturn(TEST_NETWORK_NAME); -- To view, visit http://gerrit.ovirt.org/33816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a6274614d0102ab944fad7a56b20856cced0a9a Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
