Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Add ISO and VFD uploading plugin ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34760/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py: Line 51: @plugin.event( Line 52: stage=plugin.Stages.STAGE_INIT, Line 53: ) Line 54: def _init(self): Line 55: self.environment.setdefault(osetupcons.ConfigEnv.ISO_PATHS_TO_UPLOAD, []) environment should not contain lists, only plain objects. using complex objects will not enable answer file nor command line customization. Line 56: Line 57: @plugin.event( Line 58: stage=plugin.Stages.STAGE_SETUP, Line 59: ) -- To view, visit http://gerrit.ovirt.org/34760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b5c4ab5a16bf56c4b77b40bb76080d9420eede Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
