Sandro Bonazzola has uploaded a new change for review.

Change subject: remove password leak from ovirt-engine setup answer file
......................................................................

remove password leak from ovirt-engine setup answer file

Change-Id: Ie86186b48e04141d2ed7ee9b2185eb3a09bbc166
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1162781
Signed-off-by: Sandro Bonazzola <sbona...@redhat.com>
(cherry picked from commit aee7188f3f272c47e49daf10b012d4d314ec52db)
---
M src/sos/plugins/ovirt.py
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector 
refs/changes/37/35237/1

diff --git a/src/sos/plugins/ovirt.py b/src/sos/plugins/ovirt.py
index a98be0e..39c442a 100644
--- a/src/sos/plugins/ovirt.py
+++ b/src/sos/plugins/ovirt.py
@@ -182,5 +182,20 @@
                 r'{key}=********'.format(key=key)
             )
 
+        # Answer files contain passwords
+        for key in (
+            'OVESETUP_CONFIG/adminPassword',
+            'OVESETUP_CONFIG/remoteEngineHostRootPassword',
+            'OVESETUP_DWH_DB/password',
+            'OVESETUP_DB/password',
+            'OVESETUP_REPORTS_CONFIG/adminPassword',
+            'OVESETUP_REPORTS_DB/password',
+        ):
+            self.do_path_regex_sub(
+                r'/var/lib/ovirt-engine/setup/answers/.*',
+                r'{key}=(.*)'.format(key=key),
+                r'{key}=********'.format(key=key)
+            )
+
 
 # vim: expandtab tabstop=4 shiftwidth=4


-- 
To view, visit http://gerrit.ovirt.org/35237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie86186b48e04141d2ed7ee9b2185eb3a09bbc166
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.5
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to