Alona Kaplan has posted comments on this change.

Change subject: engine: update UpdateVdsGroupCommand
......................................................................


Patch Set 25:

(1 comment)

http://gerrit.ovirt.org/#/c/33813/25/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java:

Line 38:     private void testUpdateManagementNetworkChange(boolean 
emptyCluster,
Line 39:                                                    
Matcher<ValidationResult> expectedResult) {
Line 40:         
when(networkCluster.getClusterId()).thenReturn(TEST_CLUSTER_ID);
Line 41:         
when(vdsDao.getAllForVdsGroup(TEST_CLUSTER_ID)).thenReturn(emptyCluster ?
Line 42:                                                                    
Collections.<VDS> emptyList() :
Still unformatted.
Line 43:                                                                    
Collections.<VDS> singletonList(null));
Line 44:         assertThat(validator.managementNetworkChange(), 
expectedResult);
Line 45:     }


-- 
To view, visit http://gerrit.ovirt.org/33813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica33589687a6190c1fa595beda461470afe9a6db
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to