Alona Kaplan has posted comments on this change. Change subject: restapi: Add management value to NetworkUsage enum ......................................................................
Patch Set 26: (2 comments) Seems that you forgot to push the fixes you've done according to patchset 14 comments. http://gerrit.ovirt.org/#/c/33714/26//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-11-17 11:27:23 +0200 Line 6: Line 7: restapi: Add management value to NetworkUsage enum Line 8: Line 9: Add management value to NetworkUsage enum and pass mapp that Same comment as on patchset 14- I don't understand the sentence (maybe the 'mapp' is redundant?). Please rephrase it. Line 10: in the NetworkMapper + test. Line 11: Line 12: Change-Id: I6b197e613b78f1f34b8052544bf06e4108c3183f http://gerrit.ovirt.org/#/c/33714/26/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java File backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java: Line 8: import org.ovirt.engine.api.model.NetworkStatus; Line 9: import org.ovirt.engine.api.model.Usages; Line 10: Line 11: public class NetworkMapperTest extends AbstractInvertibleMappingTest< Line 12: Network, Same commet as on patchset 14- 1. This change isn't related to you patch. 2. Please use the standard formatter. Line 13: org.ovirt.engine.core.common.businessentities.network.Network, Line 14: org.ovirt.engine.core.common.businessentities.network.Network> { Line 15: Line 16: public NetworkMapperTest() { -- To view, visit http://gerrit.ovirt.org/33714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b197e613b78f1f34b8052544bf06e4108c3183f Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
