Alona Kaplan has posted comments on this change. Change subject: engine: update commands that might change management network ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/33416/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java: Line 222: Line 223: final NetworkClusterValidator networkClusterValidator = createNetworkClusterValidator(); Line 224: return validate(networkClusterValidator.networkBelongsToDataCenter(getVdsGroup(), managementNetwork)) Line 225: && validate(networkClusterValidator.managementNetworkAttachment(managementNetwork)) Line 226: && validate(networkClusterValidator.migrationPropertySupported()); > That checks if the migration feature is supported for this cluster This validation will block the creation of cluster with lower comp_ver than 3.3. This is not a desired behaviour. Why do you have to check if the migration feature supported in the cluster. The mgmt network is the migration fallback whether the feature is supported or not. Line 227: } Line 228: Line 229: private NetworkClusterValidator createNetworkClusterValidator() { Line 230: return new NetworkClusterValidator(createNetworkCluster(getManagementNetworkId()), -- To view, visit http://gerrit.ovirt.org/33416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I196a583ae7d8d7e373a1aca2a48e592232b18a5b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
