Sandro Bonazzola has uploaded a new change for review.
Change subject: sos: use env instead of command line for password
......................................................................
sos: use env instead of command line for password
use an env variable instead of a command line option
for passing the postgresql password to sos.
Change-Id: Id2ef847d3bc420d279195ee9ac56a8d4266e5936
Signed-off-by: Sandro Bonazzola <sbona...@redhat.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector
refs/changes/65/35165/1
diff --git a/src/__main__.py b/src/__main__.py
index 72d8142..2f74026 100755
--- a/src/__main__.py
+++ b/src/__main__.py
@@ -936,10 +936,10 @@
'-k {plugin}.dbhost=%(pg_dbhost)s '
'-k {plugin}.dbport=%(pg_dbport)s '
'-k {plugin}.username=%(pg_user)s '
- '-k {plugin}.password=%(pg_pass)s '
).format(
plugin=self._postgres_plugin,
)
+ os.putenv('PGPASSWORD', self.configuration.get('pg_pass'))
cmdline = (
'/usr/sbin/sosreport --batch -o {plugin} '
'--tmp-dir=%(local_scratch_dir)s ' + opt
--
To view, visit http://gerrit.ovirt.org/35165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2ef847d3bc420d279195ee9ac56a8d4266e5936
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
