Moti Asayag has posted comments on this change. Change subject: core: adding several CDA messages in single method ......................................................................
Patch Set 2: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/35164/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1973: getReturnValue().getCanDoActionMessages().add(message.name()); Line 1974: } Line 1975: Line 1976: /** Line 1977: * Adds one ore more messages to the {@link CommandBase#canDoAction()}'s return value. This return value will be s/ore/or the message a bit mislead, since the return value of the canDoAction is boolean, would should replace the link to {@link CommandBase#getReturnValue()} Line 1978: * sent to the client for the detailed information of why the action can't be performed. Line 1979: * Line 1980: * @param message Line 1981: * The message to add. Line 1975: Line 1976: /** Line 1977: * Adds one ore more messages to the {@link CommandBase#canDoAction()}'s return value. This return value will be Line 1978: * sent to the client for the detailed information of why the action can't be performed. Line 1979: * ... Line 1980: * @param message Line 1981: * The message to add. Line 1982: */ Line 1983: Line 1976: /** Line 1977: * Adds one ore more messages to the {@link CommandBase#canDoAction()}'s return value. This return value will be Line 1978: * sent to the client for the detailed information of why the action can't be performed. Line 1979: * Line 1980: * @param message s/message/messages - can be more than one... Line 1981: * The message to add. Line 1982: */ Line 1983: Line 1984: protected void addCanDoActionMessages(VdcBllMessages... messages) { Line 1977: * Adds one ore more messages to the {@link CommandBase#canDoAction()}'s return value. This return value will be Line 1978: * sent to the client for the detailed information of why the action can't be performed. Line 1979: * Line 1980: * @param message Line 1981: * The message to add. s/message/messages Line 1982: */ Line 1983: Line 1984: protected void addCanDoActionMessages(VdcBllMessages... messages) { Line 1985: for (VdcBllMessages msg : messages) { Line 1980: * @param message Line 1981: * The message to add. Line 1982: */ Line 1983: Line 1984: protected void addCanDoActionMessages(VdcBllMessages... messages) { final method? Line 1985: for (VdcBllMessages msg : messages) { Line 1986: addCanDoActionMessage(msg); Line 1987: } Line 1988: } -- To view, visit http://gerrit.ovirt.org/35164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7618d3a7ae8652a069f533b6212cbc6796069964 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
