Fabian Deutsch has posted comments on this change. Change subject: node: added persistent storage configuration ......................................................................
Patch Set 1: (1 comment) See my inline comments. http://gerrit.ovirt.org/#/c/34438/1/src/plugins/ovirt-hosted-engine-setup/core/misc.py File src/plugins/ovirt-hosted-engine-setup/core/misc.py: Line 101: try: Line 102: # avoid: pyflakes 'Config' imported but unused error Line 103: import ovirt.node.utils.fs Line 104: if hasattr(ovirt.node.utils.fs, 'Config'): Line 105: self.environment[ohostedcons.CoreEnv.NODE_SETUP] = True Shouldn't we raise an error here if we can not find the Config attr? Line 106: except ImportError: Line 107: self.logger.debug('Disabling persisting file configuration') Line 108: Line 109: @plugin.event( -- To view, visit http://gerrit.ovirt.org/34438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67afe1d994437eac841cc4217ed39f68d5b12374 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
