Eli Mesika has posted comments on this change. Change subject: db: use new functionality in 0000_config.sql ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/35115/6/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 149: select fn_db_add_config_value_for_versions_up_to('GlusterRefreshHeavyWeight', 'false', '3.1'); Line 150: select fn_db_add_config_value('GlusterRefreshRateHooks', '7200', 'general'); Line 151: select fn_db_add_config_value('GlusterRefreshRateLight', '5', 'general'); Line 152: select fn_db_add_config_value('GlusterRefreshRateHeavy', '300', 'general'); Line 153: select fn_db_add_config_value_for_versions_up_to('GlusterServicesEnabled', 'false', '3.2'); I had talked with shubhendu from the Gluster team he said : "this feature was developed but later based on inputs from PMs it was disabled" So, we can safely remove this line since the default declared in ConfigValues.java which is false will be used Line 154: select fn_db_add_config_value('GlusterSupport', 'false', '3.0'); Line 155: select fn_db_add_config_value_for_versions_up_to('GlusterSupportForceCreateVolume', 'false', '3.3'); Line 156: select fn_db_add_config_value('GlusterVolumeOptionGroupVirtValue','virt','general'); Line 157: select fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general'); -- To view, visit http://gerrit.ovirt.org/35115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52e4c5b2b63650722e902c3bcca5e60cc5a88793 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
