Juan Hernandez has posted comments on this change. Change subject: restapi: add custom properties to templates ......................................................................
Patch Set 2: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/35118/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3150: <xs:element ref="virtio_scsi" minOccurs="0" maxOccurs="1"/> Line 3151: <xs:element ref="serial_number" minOccurs="0" maxOccurs="1" /> Line 3152: <xs:element name="start_paused" type="xs:boolean" minOccurs="0" maxOccurs="1" /> Line 3153: <xs:element ref="cpu_profile" minOccurs="0" maxOccurs="1"/> Line 3154: <xs:element name="custom_properties" type="CustomProperties" minOccurs="0"/> Add an explicit maxOccurs. Line 3155: </xs:sequence> Line 3156: </xs:extension> Line 3157: </xs:complexContent> Line 3158: </xs:complexType> http://gerrit.ovirt.org/#/c/35118/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java: Line 239: model.setCpuProfile(cpuProfile); Line 240: } Line 241: Line 242: if (!StringUtils.isEmpty(entity.getCustomProperties())) { Line 243: CustomProperties hooks = new CustomProperties(); Why is this named "hooks"? It is confusing. Line 244: hooks.getCustomProperty().addAll(CustomPropertiesParser.parse(entity.getCustomProperties(), false)); Line 245: model.setCustomProperties(hooks); Line 246: } Line 247: } -- To view, visit http://gerrit.ovirt.org/35118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95261d17138a8a19d52b16f7f84322c051d7bf17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
