Martin Peřina has posted comments on this change.

Change subject: db: use new functionality in 0000_config.sql
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/35115/3/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql:

Line 153: GlusterServicesEnabled
GlusterServicesEnabled is false by default, possible error?


Line 462: select fn_db_add_config_value('SupportedStorageFormats','0,2','3.0');
Line 463: select fn_db_add_config_value_for_versions('SupportedStorageFormats', 
'0,2,3','3.5');
Line 464: select 
fn_db_add_config_value('SupportedVDSMVersions','4.9,4.10,4.11,4.12,4.13,4.14','general');
Line 465: 
Line 466: select fn_db_add_config_value_for_versions('SupportForceCreateVG', 
'false','3.0');
Since 3.0 is the lowest supported version, we can leave fn_db_add_config_value 
here
Line 467: select fn_db_add_config_value_for_versions('SupportForceExtendVG', 
'false','3.1');
Line 468: select fn_db_add_config_value('SysPrepDefaultPassword','','general');
Line 469: select fn_db_add_config_value('SysPrepDefaultUser','','general');
Line 470: select 
fn_db_add_config_value('ThrottlerMaxWaitForVdsUpdateInMillis','10000','general');


-- 
To view, visit http://gerrit.ovirt.org/35115
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52e4c5b2b63650722e902c3bcca5e60cc5a88793
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to