Moti Asayag has posted comments on this change. Change subject: core: remove possiblity of replacements being null ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35124/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java: Line 52: throw new IllegalArgumentException("message must not be null"); Line 53: } Line 54: Line 55: this.message = message; Line 56: this.variableReplacements = variableReplacements == null ? I'd extend the condition to an empty variableReplacements array which is the more common case of using ValidationResult: this.variableReplacements = variableReplacements == null || variableReplacements.length == 0 ? ... Line 57: Collections.<String>emptyList() : Line 58: Collections.unmodifiableList(Arrays.asList(variableReplacements)); Line 59: } Line 60: -- To view, visit http://gerrit.ovirt.org/35124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice3c566c4e77204c3d6eb0e2b24ec68210cbc8d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
