Michael Pasternak has posted comments on this change. Change subject: [WIP] Remove logging dependencies ......................................................................
Patch Set 4: -Code-Review Hi Juan, The thing is that even when you remove log4j from the sdk, sdk user still have no much of freedom as Apache HttpClinet uses 'Commons Logging', so pre-configuring log4j (only valid option there in these days (in my view)) was making sense then, i guess if we really wanted to give logging freedom we should implementing JCL bridge for slf4j (which is facade only), then one could use any modern logger like logback etc. so i think we not letting users to choose, but rolling responsibility to them (implementing bridges etc.) and on the way loosing by-default logging capabilities (that might be already in use by someone btw) in any case i'm backing off letting you to make the call. -- To view, visit http://gerrit.ovirt.org/34900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id81d1490f9f5594e8065b8a20c71d9595d35814b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
