anmolbabu has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/33845/17/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java: Line 35: Line 36: private List<GlusterVolumeEntity> getAllGlusterVolumesWithMasterCompatibleVersion(Guid masterVolumeId) { Line 37: GlusterVolumeEntity masterVolume = getGlusterVolumeDao().getById(masterVolumeId); Line 38: VDSGroup masterCluster = getVdsGroupDao().get(masterVolume.getClusterId()); Line 39: List<VDSGroup> clusters = getVdsGroupDao().getGeoRepEligibleVdsGroups(masterCluster.getId(), masterCluster.getcompatibility_version().getValue()); > I think the earlier query was more generic - getClustersByServiceAndCompati Done.I probably misinterpreted your comment on patch set 15 Line 40: List<GlusterVolumeEntity> volumes = new ArrayList<GlusterVolumeEntity>(); Line 41: if(clusters != null) { Line 42: for(VDSGroup currentCluster : clusters) { Line 43: volumes.addAll(getGlusterVolumeDao().getByClusterId(currentCluster.getId())); -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
