[Engine-patches] Change in ovirt-engine[master]: webadmin: create snapshot - filter out non-snapable disks

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: webadmin: create snapshot - filter out non-snapable disks
......................................................................

webadmin: create snapshot - filter out non-snapable disks

Create snapshot dialog:
Filter out non-snapable disks (shareable/DirectLUN) from list
(a relevant validation and warning already exists).

Change-Id: I7bfc4fbaa254ca7ac8c5f37decbcd78fcf991636
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
2 files changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/35112/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
index 59b1d65..85ecd6b 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
@@ -1378,6 +1378,16 @@
         }
     }
 
+    public final static <T extends Disk> Collection<T> filterNonSnapableDisks(
+            Collection<Disk> source) {
+        return (Collection<T>) where(source, new IPredicate<Disk>() {
+            @Override
+            public boolean match(Disk source) {
+                return source.isAllowSnapshot();
+            }
+        });
+    }
+
     public final static <T extends Disk> Collection<T> 
filterDisksByStorageType(
             Collection<Disk> source, final DiskStorageType diskStorageType) {
         return (Collection<T>) where(source, new IPredicate<Disk>() {
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
index a2e0272..555328e 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
@@ -290,8 +290,7 @@
     }
 
     private void updateSnapshotDisks(ArrayList<Disk> disks) {
-        ArrayList<DiskImage> diskImages =
-                Linq.toList(Linq.<DiskImage>filterDisksByStorageType(disks, 
Disk.DiskStorageType.IMAGE));
+        ArrayList<DiskImage> diskImages = 
Linq.toList(Linq.<DiskImage>filterNonSnapableDisks(disks));
         Collections.sort(diskImages, new Linq.DiskByAliasComparer());
         getSnapshotDisks().setItems(diskImages);
     }


-- 
To view, visit http://gerrit.ovirt.org/35112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bfc4fbaa254ca7ac8c5f37decbcd78fcf991636
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches