Eli Mesika has posted comments on this change.
Change subject: backend: Fix 'remove-quota' canDo logic (#844652)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
please apply minor comments
....................................................
File backend/manager/dbscripts/quota_sp.sql
Line 237: WHERE quota_id = v_quota_id) then
Indentation:
if EXISTS (SELECT quota_id
FROM images
WHERE quota_id = v_quota_id
UNION
SELECT quota_id
FROM vm_static
WHERE quota_id = v_quota_id) then
....................................................
Commit Message
Line 15: Don't allow to delet the quota
delet => delete
--
To view, visit http://gerrit.ovirt.org/6926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ed5166fc1b8fec94b3f90013ef76474f33b327d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
