Lior Vernia has posted comments on this change. Change subject: engine,webadmin: Replace references to NetworkQoS with HostNetworkQos ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34131/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 56: protected static final String ENGINE_NETWORK = Line 57: (String) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.ManagementNetwork); Line 58: public static final HostNetworkQos EMPTY_HOST_NETWORK_QOS; Line 59: Line 60: static { > static initializers should be avoided if possible ~ their context is too br Done Line 61: EMPTY_HOST_NETWORK_QOS = new HostNetworkQos(); Line 62: EMPTY_HOST_NETWORK_QOS.setName(ConstantsManager.getInstance().getConstants().unlimitedQoSTitle()); Line 63: EMPTY_HOST_NETWORK_QOS.setId(Guid.Empty); Line 64: } -- To view, visit http://gerrit.ovirt.org/34131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6a625d8c5b554cb525efc41d31013df0de2a146 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
