Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: Support replacements in ValidationResult ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34855/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java: Line 52: } Line 53: Line 54: this.message = message; Line 55: if (variableReplacements.length > 0) { Line 56: this.variableReplacements = Collections.unmodifiableList(Arrays.asList(variableReplacements)); > well...couldn't prove it by running the following tests, which later own I sorry my fault. I was thinking of Apache common-collections implementation rather than javav.util.Collections class. However as soon as you wrote the tests why didn't you add them to the patch?! Line 57: } Line 58: } Line 59: Line 60: /** -- To view, visit http://gerrit.ovirt.org/34855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2bd85af2d129e0647b100b90908a1314419da2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
