[Engine-patches] Change in ovirt-engine[master]: engine: Use specific method to resolve command classes

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: engine: Use specific method to resolve command classes
......................................................................

engine: Use specific method to resolve command classes

Change-Id: I2ec45e31f7c72dd5659e1b5fcb81a632cb8b34d4
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/35078/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
index f8be7e2..134c9c6 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
@@ -82,8 +82,8 @@
     private static <P extends VdcActionParametersBase> CommandBase<P> 
instantiateCommand(VdcActionType action, P parameters, CommandContext 
commandContext)
             throws InstantiationException, IllegalAccessException, 
IllegalArgumentException, InvocationTargetException {
         return commandContext == null ?
-                
(CommandBase<P>)findCommandConstructor(getCommandClass(action.name(), 
COMMAND_SUFFIX), parameters.getClass()).newInstance(parameters)
-                : (CommandBase<P>) 
findCommandConstructor(getCommandClass(action.name(), COMMAND_SUFFIX),
+                (CommandBase<P>) 
findCommandConstructor(getCommandClass(action.name()), 
parameters.getClass()).newInstance(parameters)
+                : (CommandBase<P>) 
findCommandConstructor(getCommandClass(action.name()),
                         parameters.getClass(),
                         commandContext.getClass()).newInstance(parameters, 
commandContext);
     }
@@ -154,11 +154,13 @@
     }
 
     public static <P extends VdcActionParametersBase> boolean 
hasConstructor(VdcActionType action, P parameters) {
-        return ReflectionUtils.findConstructor(getCommandClass(action.name(), 
COMMAND_SUFFIX), parameters.getClass()) != null;
+        return ReflectionUtils.findConstructor(getCommandClass(action.name()), 
parameters.getClass()) != null;
     }
 
     public static <P extends VdcActionParametersBase> boolean 
hasConstructor(VdcActionType action, P parameters, CommandContext cmdContext) {
-        return ReflectionUtils.findConstructor(getCommandClass(action.name(), 
COMMAND_SUFFIX), parameters.getClass(), cmdContext.getClass()) != null;
+        return ReflectionUtils.findConstructor(getCommandClass(action.name()),
+                parameters.getClass(),
+                cmdContext.getClass()) != null;
     }
 
     private static Class<CommandBase<? extends VdcActionParametersBase>> 
getCommandClass(String name, String suffix) {


-- 
To view, visit http://gerrit.ovirt.org/35078
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ec45e31f7c72dd5659e1b5fcb81a632cb8b34d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches