Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: add element ids to all general subtabs ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/34800/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java: Line 38: TextBoxLabel monitorCount = new TextBoxLabel(); Line 39: @Ignore Line 40: TextBoxLabel isStateless = new TextBoxLabel(); Line 41: Line 42: CommonApplicationConstants constants; > Please consider making this field private and final. Done Line 43: Line 44: private final Driver driver = GWT.create(Driver.class); Line 45: Line 46: public TemplateGeneralModelForm(ModelProvider<TemplateGeneralModel> modelProvider, http://gerrit.ovirt.org/#/c/34800/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java: Line 30: Line 31: @Ignore Line 32: TextBoxLabel monitorCount = new TextBoxLabel(); Line 33: Line 34: CommonApplicationConstants constants; > Please consider making this field private and final. Done Line 35: Line 36: private final Driver driver = GWT.create(Driver.class); Line 37: Line 38: public PoolGeneralModelForm(ModelProvider<PoolGeneralModel> modelProvider, CommonApplicationConstants constants) { http://gerrit.ovirt.org/#/c/34800/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java: Line 42: Line 43: @Ignore Line 44: TextBoxLabel monitorCount = new TextBoxLabel(); Line 45: Line 46: CommonApplicationConstants constants; > Please consider making this field private and final. Done Line 47: Line 48: private final Driver driver = GWT.create(Driver.class); Line 49: Line 50: public VmGeneralModelForm(ModelProvider<VmGeneralModel> modelProvider, CommonApplicationConstants constants) { http://gerrit.ovirt.org/#/c/34800/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java: Line 36: TextBoxLabel compatibilityVersion = new TextBoxLabel(); Line 37: TextBoxLabel emulatedMachine = new TextBoxLabel(); Line 38: TextBoxLabel numberOfVms = new TextBoxLabel(); Line 39: Line 40: ApplicationConstants constants; > Please consider making this field private and final. Done Line 41: Line 42: private final Driver driver = GWT.create(Driver.class); Line 43: Line 44: public ClusterGeneralModelForm(ModelProvider<ClusterGeneralModel> modelProvider, -- To view, visit http://gerrit.ovirt.org/34800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b281e7b130dd0bbcb23887719e79ab615a901d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
