Roy Golan has posted comments on this change. Change subject: core: validate profile is not attached before removing it ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/33903/6/packaging/dbscripts/disk_images_sp.sql File packaging/dbscripts/disk_images_sp.sql: Line 207: RETURNS SETOF images_storage_domain_view STABLE Line 208: AS $procedure$ Line 209: BEGIN Line 210: RETURN QUERY SELECT images_storage_domain_view.* Line 211: FROM images_storage_domain_view and if we activate a storage domain back we might have disks with non-existing profiles? Line 212: WHERE active AND images_storage_domain_view.disk_profile_id = v_disk_profile_id; Line 213: END; $procedure$ Line 214: LANGUAGE plpgsql; Line 215: -- To view, visit http://gerrit.ovirt.org/33903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic927e020118354751943b9890daef52373e3896f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
