Maor Lipchuk has posted comments on this change. Change subject: core: avoid adding ovf store when register disk fails ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/33356/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 270: getParameters().getStorageDomainId(), Line 271: registerDiskResult ? "succeeded" : "failed"); Line 272: Line 273: if (registerDiskResult) { Line 274: log.infoFormat("Adding OVF_STORE disk with disk id {0} to storage domain {1}", we already have a log indicating this, there is no benefit to add another one Line 275: ovfStoreDiskImage.getId(), Line 276: getParameters().getStorageDomainId()); Line 277: addOvfStoreDiskToDomain(ovfStoreDiskImage); Line 278: } -- To view, visit http://gerrit.ovirt.org/33356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
