Martin Sivák has posted comments on this change. Change subject: Separate constants from rules to collector, read it from XML ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34688/1/mom/Collectors/GuestMemory.py File mom/Collectors/GuestMemory.py: Line 29: hypervisor isn't able to provide its own values. Line 30: """ Line 31: return {'min_guest_free_percent': 0.2, Line 32: 'max_balloon_change_percent': 0.05, Line 33: 'min_balloon_change_percent': 0.0025} > Hmm... I'm not convinced that trying these to the Collector is a good idea. I agree with Adam. I would create another collector (CustomGuestBalooning or such..) that would report the values in the usual way and then used them in the policy. Also let us synchronize on the metadata section and key names. We might want to implement it in vdsm as well in the future. Line 34: Line 35: def getFields(self): Line 36: fields = self.hypervisor_iface.getStatsFields() Line 37: fields.update(self.getConstants().keys()) -- To view, visit http://gerrit.ovirt.org/34688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c16d29f6e1d541808d9c1f4051c3de0cc746098 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Pavlásek <mpavl...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Pavlásek <mpavl...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
