Tomas Jelinek has posted comments on this change. Change subject: userportal\webadmin: cluster parameters override ......................................................................
Patch Set 13: (2 comments) thank you! Last 2 comments - strange it did pass the build, it should have failed on checkstyle... When fixed will give +2 http://gerrit.ovirt.org/#/c/31582/13/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1823: } Line 1824: else if (sender == getHostCpu()) { Line 1825: if(getHostCpu().getEntity() != null && getHostCpu().getEntity()) { Line 1826: getCustomCpu().setIsChangable(false); Line 1827: getCustomCpu().setSelectedItem(""); //$NON-NLS-1$ Line 1828: } else { Line 1829: getCustomCpu().setIsChangable(true); Line 1830: } Line 1831: } http://gerrit.ovirt.org/#/c/31582/13/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java: Line 1130: @Override Line 1131: public void onSuccess(Object model, Object returnValue) { Line 1132: if (returnValue != null) { Line 1133: List<String> cpuList = new ArrayList<String>(); Line 1134: cpuList.add(""); //$NON-NLS-1$ Line 1135: for (ServerCpu cpu : (List<ServerCpu>) returnValue) { Line 1136: cpuList.add(cpu.getVdsVerbData()); Line 1137: } Line 1138: String oldVal = getModel().getCustomCpu().getSelectedItem(); -- To view, visit http://gerrit.ovirt.org/31582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia288e46f38c03935ec9b0817833b1921f15ec9f8 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
