Liron Aravot has posted comments on this change. Change subject: core: perform ovf update for domain when it's deactivated ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/33158/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java: Line 169: while (true) { Line 170: TimeUnit.SECONDS.sleep(3); Line 171: List<Guid> tasks = getDbFacade().getAsyncTaskDao().getAsyncTaskIdsByEntity(getStorageDomainId()); Line 172: if (tasks.isEmpty()) { Line 173: log.infoFormat("no tasks for the deactivated domain {0}, proceeding with deactivation", getStorageDomainId()); > /s/no tasks for the deactivated domain {0}/no tasks for the deactivated Sto Done Line 174: return; Line 175: } Line 176: } Line 177: } http://gerrit.ovirt.org/#/c/33158/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java: Line 410: missingTemplateDiskMap.put(guidListEntry.getKey(), guidListEntry.getValue()); Line 411: } else { Line 412: ImportDiskData importDiskData = diskImportDataMap.get(diskImage.getId()); Line 413: if (importDiskData.is) Line 414: importDiskData.setStorageDomains(storageDomains); > Please seperate GUI patches from engine patches the GUI changes here are 8 lines totally, there's no benefit to separate it and on such a late stage i prefer to keep as is. Line 415: } Line 416: } Line 417: } Line 418: } -- To view, visit http://gerrit.ovirt.org/33158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54cc929937d3b14dc49a2edab9e763cbe603a9c3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
