Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: fixed tabindexes for login pages ......................................................................
Patch Set 2: I lost you at the end. useManual is just a flag to disable the tabindex-setting visitor for this form. By default, I try to set the tab indexes manually in UIBinder, and then later the visitor comes along and overwrites my tabindexes. However, visitor only knows about regular form fields -- he doesn't touch select boxes or checkboxes. So the login form ends up with tabindex pattern of 1-2-1-2-3-6 or such. I don't think the visitor was written with the login form in mind, and yet it visits the login form. Not sure why. One approach would be to enhance it for the login form. Another approach is to disable it for the login form -- and that's what I chose. I don't think there's any way to tell the visitor to ignore login form by setting tabindex to -1. -- To view, visit http://gerrit.ovirt.org/34738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I434eb12b5efe003c0d1c139ad94d4d352668f403 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
