Maor Lipchuk has posted comments on this change. Change subject: engine:VM with remaining disks will not be deleted.(#822051) ......................................................................
Patch Set 5: (2 inline comments) The solution was changed to remove the VM also, since we can't count that it is valid any more, and leave the problematic disks in the setup in status ILLEGAL, since those disks might have snapshots, so they cannot be used. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 224: // Get all disk images for VM (VM should not have any image disk associated with it). There is the indication of imagesLeftInVm, when disks are left in VM, the audit log will indicate that we failed to remove the VM. Line 239: } After second discussion with Ayal, we decided to remove the VM, since we can't count that it is valid any more, and leave the problematic disks in the setup in status ILLEGAL, since those disks might have snapshots, so they cannot be used. -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
