Roy Golan has posted comments on this change. Change subject: core: OsInfo-related changes ......................................................................
Patch Set 37: (1 comment) http://gerrit.ovirt.org/#/c/30838/37/packaging/conf/osinfo-defaults.properties File packaging/conf/osinfo-defaults.properties: Line 50: os.other.resources.minimum.ram.value = 256 Line 51: os.other.resources.maximum.ram.value = 64000 Line 52: os.other.resources.minimum.disksize.value = 1 Line 53: os.other.resources.minimum.numberOsCpus.value = 1 Line 54: os.other.devices.display.protocols.value = spice/qxl,vnc/qxl,vnc/cirrus you have to update Osinfo.g4 to parse the new values look at DISPLAY_PROTOCOLS_TYPE at backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 Line 55: os.other.devices.watchdog.models.value = i6300esb Line 56: Line 57: os.other.devices.disk.hotpluggableInterfaces.value = VirtIO_SCSI, VirtIO Line 58: os.other.devices.disk.hotpluggableInterfaces.value.3.0 = -- To view, visit http://gerrit.ovirt.org/30838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c7126308ab4e5e5418d804a8550a50e9994894 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
