Yair Zaslavsky has posted comments on this change.

Change subject: setup: Changing task cleaner utility to also handle removal of 
commands
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/34927/3/packaging/setup/dbutils/taskcleaner_sp.sql
File packaging/setup/dbutils/taskcleaner_sp.sql:

Line 52: BEGIN
Line 53:         DELETE FROM async_tasks WHERE command_id = v_command_id;
Line 54:        SELECT root_command_id  into root_command_id_of_deleted_cmds 
FROM COMMAND_entities WHERE command_id = v_command_id;
Line 55:         DELETE FROM command_entities where command_id = v_command_id;
Line 56:        GET DIAGNOSTICS deleted_rows = ROW_COUNT;
> Replace tabs with spaces?
will do, thanks!
Line 57:        IF deleted_rows > 0 THEN
Line 58:                DELETE FROM command_entities C WHERE command_id = 
root_command_id_of_deleted_cmds AND NOT EXISTS (SELECT * from COMMAND_ENTITIES 
WHERE root_command_id = C.command_id);
Line 59:        END IF;
Line 60: END; $procedure$


-- 
To view, visit http://gerrit.ovirt.org/34927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f83cb7fc1f7fecb4ea68dff5cf0f3c63eeb6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to