Juan Hernandez has uploaded a new change for review. Change subject: sdk: Apply filter by name/alias after get ......................................................................
sdk: Apply filter by name/alias after get Currently, for searchable collections, the "get" method is implemented using the "search" query parameter, and returning to the caller all the results returned by the server. But when this is combined with the "Filter: true" header the server ignores the "search" query parameter, and instead it returns all the objects that the user has permissions for. This means that in some situations the user may be requesting an object and getting back a different one. To avoid this issue this patch adds an additional filtering step, so the collection returned by the server is filtered, and only the objects matching the name given by the user are taken into consideration. Change-Id: I9baf549c68a93f329b76d41a2ce52b7a7e7b6c79 Bug-Url: https://bugzilla.redhat.com/1155678 Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk refs/changes/92/34892/1 diff --git a/src/ovirtsdk/infrastructure/brokers.py b/src/ovirtsdk/infrastructure/brokers.py index c605951..9525c16 100644 --- a/src/ovirtsdk/infrastructure/brokers.py +++ b/src/ovirtsdk/infrastructure/brokers.py @@ -19,7 +19,7 @@ ############ GENERATED CODE ############ ######################################## -'''Generated at: 2014-10-28 11:29:49.000863''' +'''Generated at: 2014-11-06 15:30:29.000954''' from ovirtsdk.xml import params @@ -2599,7 +2599,7 @@ return Cluster( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -8946,7 +8946,7 @@ return DataCenter( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -9823,7 +9823,7 @@ return Disk( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'alias':alias}), query="alias=" + alias ), self.context @@ -10315,7 +10315,7 @@ return Event( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -11131,7 +11131,7 @@ return Group( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -13297,7 +13297,7 @@ return Host( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -15382,7 +15382,7 @@ return Network( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -19356,7 +19356,7 @@ return StorageDomain( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -20962,7 +20962,7 @@ return Template( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -21780,7 +21780,7 @@ return User( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context @@ -26394,7 +26394,7 @@ return VmPool( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context -- To view, visit http://gerrit.ovirt.org/34892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9baf549c68a93f329b76d41a2ce52b7a7e7b6c79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
