Juan Hernandez has uploaded a new change for review. Change subject: codegen: Apply filter by name/alias after get ......................................................................
codegen: Apply filter by name/alias after get Currently, for searchable collections, the "get" method is implemented using the "search" query parameter, and returning to the caller all the results returned by the server. But when this is combined with the "Filter: true" header the server ignores the "search" query parameter, and instead it returns all the objects that the user has permissions for. This means that in some situations the user may be requesting an object and getting back a different one. To avoid this issue this patch adds an additional filtering step, so the collection returned by the server is filtered, and only the objects matching the name given by the user are taken into consideration. Change-Id: Ia762356ee4ad12839e089de2cd60f832bd212af5 Related-To: https://bugzilla.redhat.com/1155678 Signed-off-by: Juan Hernandez <[email protected]> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate M src/ovirtsdk/infrastructure/brokers.py 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk refs/changes/91/34891/1 diff --git a/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate b/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate index 9c40bd5..10c0288 100644 --- a/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate +++ b/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate @@ -21,7 +21,7 @@ return $resource_type$( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'alias':alias}), query="alias=" + alias ), self.context diff --git a/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate b/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate index b8aa570..2f174d7 100644 --- a/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate +++ b/generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate @@ -23,7 +23,7 @@ return $resource_type$( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context diff --git a/src/ovirtsdk/infrastructure/brokers.py b/src/ovirtsdk/infrastructure/brokers.py index 75586bb..c605951 100644 --- a/src/ovirtsdk/infrastructure/brokers.py +++ b/src/ovirtsdk/infrastructure/brokers.py @@ -25995,7 +25995,7 @@ return VM( FilterHelper.getItem( - result, + FilterHelper.filter(result, {'name':name}), query="name=" + name ), self.context -- To view, visit http://gerrit.ovirt.org/34891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia762356ee4ad12839e089de2cd60f832bd212af5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
