Oved Ourfali has posted comments on this change. Change subject: core: add keystone url field to external providers ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34880/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 168: boolean authenticationRequired = requiresAuthentication.getEntity(); Line 169: getUsername().setIsChangable(authenticationRequired); Line 170: getPassword().setIsChangable(authenticationRequired); Line 171: getTenantName().setIsChangable(authenticationRequired); Line 172: getKeystoneURL().setIsChangable(authenticationRequired); Only relevant for openstack-related (neutron/glance). Line 173: } Line 174: }); Line 175: setType(new ListModel<ProviderType>() { Line 176: @Override http://gerrit.ovirt.org/#/c/34880/1/packaging/dbscripts/upgrade/03_06_0520_add_keystone_url.sql File packaging/dbscripts/upgrade/03_06_0520_add_keystone_url.sql: Line 1: SELECT fn_db_add_column('providers', 'keystone_url', 'TEXT DEFAULT NULL'); Line 2: Line 3: UPDATE providers set keystone_url = (select option_value from vdc_options where option_name = 'KeystoneAuthUrl') Line 4: WHERE auth_required; only needed for openstack related (neutron and glance). Line 5: Line 6: -- this must be done here since 0000_config.sql is running in the pre-upgrade stage Line 7: Line 8: select fn_db_delete_config_value('KeystoneAuthUrl','general'); -- To view, visit http://gerrit.ovirt.org/34880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1aa930cd8dec576a6408402dd883ab5162e1f9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
